-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Firefox Nightly adds ShadowRoot.setHTML()
and sanitizer parameter
#26815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once FF140 becomes nightly, these would change to "preview".
Based on https://whattrainisitnow.com/, Firefox 140 currently is Nightly.
Is this planned to ship in 140? Then we can keep it as is, otherwise we should set it to "preview"
now.
I think this is still missing the sanitizer option for Element.setHTMLUnsafe.
No |
I hadn't caught this, but considering these methods aren't available by default, shouldn't the compat info have the pref instead of a version? |
Are these behind a pref even in Nightly? (Then yes.) |
@hamishwillee PTAL at the comments above. If the feature is not available by default in Nightly, then we should set |
@caugner They are behind a flag that is enabled in nightly. FYI only, the reason they were previously behind the flag was because when I started this process FF140 was not nightly, and that was the version this went in with. |
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
ShadowRoot.setHTML()
and sanitizer parameter
FF140 adds remaining sanitizer method/options behind flag in https://bugzilla.mozilla.org/show_bug.cgi?id=1959727
Once FF140 becomes nightly, these would change to "preview".
Changes are:
options.sanitizer
added to param toShadowRoot.setHTMLUnsafe()
andDocument.parseHTMLUnsafe()
This follows on from #26659
FYI @evilpie I was "somewhat wrong" in #26659. I can add them, just not as a "preview" release. I didn't think of this properly because I was so focused on FF139.
Related docs work being done in mdn/content#38890